Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing extra body height declaration, adding scroll-behavior: auto … #2

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

lukehler
Copy link

…for prefers-reduced motion.

@mike-engel mike-engel merged commit 9c6c13c into mike-engel:master Jun 25, 2019
@lukehler
Copy link
Author

Issues and pull requests are welcome, but because this is an interview test project, I may not respond and/or merge PRs.

I just wanted to acknowledge that this pull request isn't intended to address a pressing need, but as a demonstration. It was primarily as a quick overview of how to contribute to a project for a mostly non-technical (but interested!) audience. Thanks for sharing this and TIL about the list-styles

@mike-engel
Copy link
Owner

@lukehler That was actually copy/pasted from another project, so I need to update that. Good catch!

@mike-engel
Copy link
Owner

@all-contributors please add @lukehler for code

@allcontributors
Copy link
Contributor

@mike-engel

I've put up a pull request to add @lukehler! 🎉

@mike-engel
Copy link
Owner

@lukehler This is now available with version 1.1.0. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants