Allow base64 encoded bytes as argument to --secret #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-engel
requested changes
Sep 17, 2021
There was a problem hiding this comment.
@ceharris Thanks for the PR, and congrats on your first contribution to a rust project! Just a few notes, otherwise I think this PR is a good addition!
ceharris
changed the title
mike-engel
requested changes
Sep 21, 2021
There was a problem hiding this comment.
Sorry for the review delay @ceharris! Just a few notes for the tests, otherwise this looks great!
mike-engel
approved these changes
Sep 28, 2021
|
Thanks again for this @ceharris! There are a few other breaking changes on |
|
Thanks to you for making jwt-cli! Happy to contribute a little... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To simplify use in scripted applications, this PR adds a new
b64:format prefix for the--secretargument, to allow the secret to be specified as base64-encoded bytes.The same outcome can be achieved by writing the bytes of the key to a file and using
--secret @filename, but directly supporting base64 avoids the need to write the key to a file.Example
N.B. -- this is my first experience contributing to a Rust-based project.