Adding `--date' argument to configure time format #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--iso8601 was too hard for me to remember, and most often than not I want to see the time in my local timezone
jazcarate
force-pushed
the
add-date-arg
branch
from
a86f29e
to
fdec7b4
Compare
mike-engel
requested changes
Feb 4, 2023
| match parse(&mut parsed, arg, StrftimeItems::new("%#z")) { | ||
| Ok(_) => match parsed.offset { | ||
| Some(offset) => Ok(TimeFormat::Fixed(offset)), | ||
| None => panic!("Should have been able to parse the offset"), |
There was a problem hiding this comment.
A better error message would be something long the lines of, "{arg} could not be parsed as a UTC offset"
There was a problem hiding this comment.
This panic should never ever happen. The format (%#z) is an offset format, so there is no way parsed.offset is a None.
For example, a format like "%H:%M:%S" has a None offset.
The error when you input something that is not an offset is the Err(_) in the next line
mike-engel
approved these changes
Feb 16, 2023
|
Very sorry for the delay, but this is in 6.0.0 now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--iso8601was too hard for me to remember, and most often than not I want to see the time in my local timezonePreflight checklist