Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Add support for EdDSA #238

Merged
merged 3 commits into from
Feb 1, 2023

Conversation

lloydmeta
Copy link
Contributor

Summary

Does what it says on the tin:

  • Adds EdDSA as a supported algo
  • Adds EdDSA key loading

Preflight checklist

  • Code formatted with rustfmt
  • Relevant tests added
  • Any new documentation added

Closes #177

Does what it says on the tin:
- Adds EdDSA as a supported algo
- Adds EdDSA key loading

Signed-off-by: lloydmeta <lloydmeta@gmail.com>
@lloydmeta lloydmeta marked this pull request as ready for review January 28, 2023 13:23
Copy link
Owner

@mike-engel mike-engel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @lloydmeta! Just one little thing, then this is good to go

tests/main_test.rs Outdated Show resolved Hide resolved
Signed-off-by: lloydmeta <lloydmeta@gmail.com>
Signed-off-by: lloydmeta <lloydmeta@gmail.com>
@mike-engel mike-engel merged commit 59e06a6 into mike-engel:main Feb 1, 2023
@lloydmeta lloydmeta deleted the feature/eddsa-support branch February 1, 2023 07:25
@mike-engel
Copy link
Owner

Very sorry for the delay, but this is in 6.0.0 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for EdDSA (or don't validate the algorithm)
2 participants