fix: raw JWKS --secret for ES256/ES384 alg #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
vdbulcke
force-pushed
the
fix-es-jwk-secret
branch
from
81a31ae
to
f247c62
Compare
mike-engel
reviewed
Jan 20, 2024
Comment on lines
+818
to
+819
| let jwks = r#"{"keys":[{"use":"sig","kty":"EC","kid":"4h7wt2IHHu_RLR6OtlZjCe_mIt8xAReS0cDEwwWAeKU","crv":"P-256","x":"w7JAoU_gJbZJvV-zCOvU9yFJq0FNC_edCMRM78P8eQQ","y":"wQg1EytcsEmGrM70Gb53oluoDbVhCZ3Uq3hHMslHVb4"},{"use":"enc","kty":"EC","kid":"4h7wt2IHHu_RLR6OtlZjCe_mIt8xAReS0cDEwwWAeKU","crv":"P-256","x":"w7JAoU_gJbZJvV-zCOvU9yFJq0FNC_edCMRM78P8eQQ","y":"wQg1EytcsEmGrM70Gb53oluoDbVhCZ3Uq3hHMslHVb4"}]} | ||
| "#; |
There was a problem hiding this comment.
Shouldn't this use the @ file notation rather than a raw string, similar to the encode step above?
There was a problem hiding this comment.
The idea is that since typically the JWKS is hosted on a remote server, that needs to be download over https, this allows to validate a JWT signature as a one-liner:
for example:
jwt decode $JWT_TOKEN --secret "$( curl -s https://www.googleapis.com/oauth2/v3/certs)" --alg RS256
Instead of
## first download JWKS as JSON file
curl -s https://www.googleapis.com/oauth2/v3/certs -o /tmp/jwks.json
## then validate the JWT signature
jwt decode $JWT_TOKEN --secret @/tmp/jwks.json --alg RS256
Also there is another test that uses the @./tests/pub_ecdsa_jwks.json file notation here https://github.com/mike-engel/jwt-cli/blob/main/tests/main_test.rs#L782.
mike-engel
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix passing raw JWKS as --secret (e.g.
--secret "$(curl https://auth.domain.com/jwks.json)") for ES256/ES384 alg.Relates to #299.
Preflight checklist
$ cargo fmt)$ cargo clippy)