-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCEMENT] Record frequency on correctly spelled words only #470
Comments
That is a very interesting idea! Personally I sometimes want to record words which are not in dictionaries for special purposes. But not always, and even I probably want to only record words from dictionaries most of the time. So maybe a new option ☑️ Record only words which are n dictionaries would be good? By the way, currently you can already manually remove unwanted suggestions from the database, the default key binding for this is
Also, the database is cleaned up a bit already at each restart of ibus-typing-booster, a few entries which have not been used much and have not been used for a long time are removed. Currently there is a hardcoded limit of 50000 entries for the database, if that limit is exceeded, old entries (not used for a long time) are removed until no more than 50000 entries remain. On top of that, no matter how many entries there are in the database, 0.1% of oldest (least used) entries are removed immediately if they have been used only once and if they have been used more than once their usage count is cut in half. So mispelled entries will eventually fade out and disappear automatically althought that can take some time. So maybe such a new option is a good idea. |
@mike-fabian Thanks for the detail. Maybe the option can be named
|
There is already a checkbox option ☑️ Off the record mode If that is checked, nothing is recorded in the user database.
Advantage:
Disadvantage:
I am thinking about the details how this should work. |
Resolves: #470 Chooses which words to record (words are called “phrases” in the source code for historic reasons): 0: Everything 1: Correctly spelled or previously recorded 2: Correctly spelled 3: Nothing I left the existing option ☑️ Off the record mode there for the moment. It works as it always did. Setting the new “Record mode” option to 3 and checking “Off the record mode” does the same thing so this seems a bit redundant. But the advantage is that one can quickly toggle recording to off using “Off the record mode” with a keybinding and when toggling it on again return to the operation of the selected “Record mode” in the combobox option. I could maybe remove the option “3: Nothing” from the combobox to remove redundancy… As I added one more row to the options tab of the setup tool, I saved one row by putting the two buttons [ Learn from text file ] [ Delete learned data ] into the same row.
I have implemented a new combobox option “Record mode” now. It chooses which words to record
I left the existing option
there for the moment. It works as it always did. Setting the new I could maybe remove the option “3: Nothing” from the combobox to remove redundancy… On the other hand that redundancy doesn’t hurt. As I added one more row to the options tab of the setup tool, I saved one [ Learn from text file ] [ Delete learned data ] into the same row. |
Test builds of ibus-typing-booster-2.24.13 with the new feature are available for Fedora 38, 39, and rawhide here: https://copr.fedorainfracloud.org/coprs/mfabian/ibus-typing-booster/builds/ and for openSUSE here: https://build.opensuse.org/package/show/home:mike-fabian/ibus-typing-booster Can you please test this? Is the wording of the option values OK? Is the text of the tooltip shown when hovering with the mouse over the option OK?:
|
Resolves: #470 Chooses which words to record (words are called “phrases” in the source code for historic reasons): 0: Everything 1: Correctly spelled or previously recorded 2: Correctly spelled 3: Nothing I left the existing option ☑️ Off the record mode there for the moment. It works as it always did. Setting the new “Record mode” option to 3 and checking “Off the record mode” does the same thing so this seems a bit redundant. But the advantage is that one can quickly toggle recording to off using “Off the record mode” with a keybinding and when toggling it on again return to the operation of the selected “Record mode” in the combobox option. I could maybe remove the option “3: Nothing” from the combobox to remove redundancy… As I added one more row to the options tab of the setup tool, I saved one row by putting the two buttons [ Learn from text file ] [ Delete learned data ] into the same row.
New option is included in ibus-typing-booster 2.25.0: |
Is your feature request related to a problem? Please describe.
I've installed ibus-typing-browser for my children who are learning words.
With record mode disabled, most of the suggested words are useless because previously typed words are not recorded.
With record mode enabled, words with wrong spelling are added and later suggested.
Describe the solution you'd like
Record only when last typed word is in dictionary.
Describe alternatives you've considered
Cleaning up the DB from time to time.
Additional context
The text was updated successfully, but these errors were encountered: