Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README #22

Closed
2 of 3 tasks
mike-koch opened this issue Oct 3, 2015 · 4 comments
Closed
2 of 3 tasks

Update README #22

mike-koch opened this issue Oct 3, 2015 · 4 comments
Assignees
Milestone

Comments

@mike-koch
Copy link
Owner

  • Update feature list in the README to include mini-map support
  • Update screenshots to showcase the new look and mini-map
  • Add contributors section to README
@mike-koch mike-koch self-assigned this Oct 3, 2015
@mike-koch mike-koch added this to the 3.0.0 milestone Oct 3, 2015
@mike-koch
Copy link
Owner Author

@denilsonsa, I was working on new screenshots, and I noticed that the markup for showing the gear shifter icon on the top row was commented out. Any reason why? I enabled it temporarily and it looked good to me... I just wasn't sure if I was missing anything.

@denilsonsa
Copy link
Contributor

The reason was because it was taking too much valuable space, specially because the weekdays were not abbreviated.

Now that you have enabled the gear icon and shortened the weekday, we may want to reduce the flex-basis: 9em from div._time. We may also increase flex-basis: 2em to 2.5em or 3em (maybe in a new rule just for the gear). Anyway, just try testing it by resizing the window (like in here).

@mike-koch
Copy link
Owner Author

I modified the CSS so that div._time and div._speed share the same width (I'm not sure if the in-game advisor uses the same length for both sections or not.... I'm RDP'ed into my Windows box so I can't check it out yet). I also gave div._gear it's own rule to increased flex-basis to 2.5. It seems to work well so far.

mike-koch added a commit that referenced this issue Oct 4, 2015
mike-koch added a commit that referenced this issue Oct 4, 2015
mike-koch added a commit that referenced this issue Oct 4, 2015
mike-koch added a commit that referenced this issue Oct 4, 2015
@mike-koch mike-koch mentioned this issue Oct 4, 2015
@denilsonsa
Copy link
Contributor

I'm not sure if the in-game advisor uses the same length for both sections or not

I just checked a screenshot, speed was about 90px, time was about 110px.

Still, as long as everything fits nicely, that's fine. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants