Use evalsha for scripts #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@mike-marcacci can you please look at this PR? |
ramhr
reviewed
Jul 23, 2020
redlock.js
Outdated
| return server.evalsha(script.hash, args, (err, result) => { | ||
| if(err !== null && err.message.startsWith("NOSCRIPT")) { | ||
| // load the script, but don't wait for it, on the next call it will be available | ||
| server.script('load', script.value); |
There was a problem hiding this comment.
If you call regular eval later you don't need to call load, as it automatically caches the script.
https://redis.io/commands/eval#script-cache-semantics
Executed scripts are guaranteed to be in the script cache of a given execution of a Redis instance forever. This means that if an EVAL is performed against a Redis instance all the subsequent EVALSHA calls will succeed.
Lazy loading the scripts: trying with evalsha if it fails on “NO SCRIPT” we will load the script (using eval) so next run will have evalsha.
ramhr
approved these changes
Jul 26, 2020
|
@mike-marcacci can you please CR this PR? |
|
@mike-marcacci if you can, please look at this PR :) |
mike-marcacci
approved these changes
Oct 4, 2020
|
Sorry for the delay - it's been a busy year 😬 Hoping to cut a new release shortly. |
|
@mike-marcacci thanks a lot, totally understandable :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lazy loading the scripts: trying with evalsha if it fails on “NO SCRIPT” we will run eval (which will load the script) and next call will use evalsha.
#76