upgrade to use lodash 4.17.2

[tchak]

---

From @mike-north:
Because lodash-4 makes use of WeakMap, where available, and because in the ember ecosystem that will come by way of babel (v6 to be specific), this is blocked by a core ember-cli issue (and really an ember-cli-babel issue)

• Babel 6.0 ember-cli/ember-cli#5015 Babel 6.0
• Babel 6.0 emberjs/ember-cli-babel#62 Babel 6.0

This isn't a trivial change to make, since we make broad use of babel in the ember ecosystem. If people want to help out, here are some upstream issues that are blocking progress on ember-cli (see here for the source of truth on status)

• update broccoli-babel-transpiler (6.0 babel/broccoli-babel-transpiler#62)
• update babel-plugin-feature-flags (Port plugin to Babel 6 plugin API ember-cli/babel-plugin-feature-flags#6)
• update babel-plugin-filter-imports (Port plugin to Babel 6 plugin API ember-cli/babel-plugin-filter-imports#6)
• update babel-plugin-htmlbars-inline-precompile (Port plugin to Babel 6 ember-cli/babel-plugin-htmlbars-inline-precompile#8)
• update ember-cli-htmlbars-inline-precompile (ember-cli/ember-cli-htmlbars-inline-precompile)
• update ember-cli-babel (Babel 6.0 emberjs/ember-cli-babel#62)
• update emberjs-build ([WIP] Babel 6 emberjs/emberjs-build#165)

[fpauser]

Why is this needed?

[tchak]

It should not be needed, but right now without it there is a crash in environments without native WeakMap support (like PhantomJS) :( I am trying to figure out what's happening.

[tchak]

The problem is that if WeakMap is undefined, lodash-es is trying to export default undefined value, and it seems that during transpilation we getting an object with default property that contains some junk instead of undefined...

[fpauser]

Ah, thanks for pointing out!

[jdalton]

Ah, I wasn't aware of this (no one brought it up). I'll look into this.

Update:
I believe this is resolved in Babel 6. It should even work with babel-plugin-add-module-exports.

[tchak]

@jdalton unfortunately ember-cli is stuck on babel 5 /cc @stefanpenner

[stefanpenner]

why am i being cc'd ?

[tchak]

@stefanpenner Sorry should have been more explicit. I rapidly mentioned to you this issue at EmberConf. The problem here is that null/undefined exports are imported as complex objects (instead of null/undefined). You said that maybe you had an idea of what the problem/fix might be.

[kellyselden]

FYI I just tried out this branch, and it worked without issue. Using
import intersectionWith from 'lodash/intersectionWith';

[tchak]

@kellyselden is includePolyfill set to true in your projects ember-cli-build.js?

[kellyselden]

@tchak Nope. No babel options.

[tchak]

@kellyselden Two reasons it works for you I think. First, you using individual import. So some parts of lodash are not executed. Second, if you trying on half recent chrome or firefox, they probably support WeakMap, Map and Set. When I test with recent browsers, test only fails in PhantomJS. But I definitely do not want for the addon to surprisingly crash on older browsers...

[urbany]

Any update on this?

[Blackening999]

Updates????

[musaffa]

@tchak Any update?

[devinus]

Why does lodash require WeakMap support?

[jdalton]

Lodash uses WeakMap when it's available to store function wrapper metadata.
The issue here is ember-lodash is stuck on an older buggier Babel version.

[tchak]

I must say, I ended up using embor-browserify for lodash on my current project given that even without this problem there is no lodash/fp es build, and I am only using lodash/fp...

[mike-north]

Because lodash-4 makes use of WeakMap, where available, and because in the ember ecosystem that will come by way of babel (v6 to be specific), this is blocked by a core ember-cli issue (and really an ember-cli-babel issue)

• Babel 6.0 ember-cli/ember-cli#5015 Babel 6.0
• Babel 6.0 emberjs/ember-cli-babel#62 Babel 6.0

This isn't a trivial change to make, since we make broad use of babel in the ember ecosystem. If people want to help out, here are some upstream issues that are blocking progress on ember-cli (see here for the source of truth on status)

• update broccoli-babel-transpiler (6.0 babel/broccoli-babel-transpiler#62)
• update babel-plugin-feature-flags (Port plugin to Babel 6 plugin API ember-cli/babel-plugin-feature-flags#6)
• update babel-plugin-filter-imports (Port plugin to Babel 6 plugin API ember-cli/babel-plugin-filter-imports#6)
• update babel-plugin-htmlbars-inline-precompile (Port plugin to Babel 6 ember-cli/babel-plugin-htmlbars-inline-precompile#8)
• update ember-cli-htmlbars-inline-precompile (ember-cli/ember-cli-htmlbars-inline-precompile)
• update ember-cli-babel (Babel 6.0 emberjs/ember-cli-babel#62)
• update emberjs-build ([WIP] Babel 6 emberjs/emberjs-build#165)

[stefanpenner]

@jdalton both sides have bugs. v5 and v6 :( Its tricky to balance those trade-offs.

[stefanpenner]

but remember as long as your addon produces ES5 safe deanonymized AMD we don't care how you go there, if babel 6 works in your addon, it is fine to use.

[josemarluedke]

Is there anything we can do to get this rolling again? I guess I don't understand the issue here with babel 6, but is there any other alternative to make this upgrade?

[tchak]

It works! I found a way!

Exports of undefined values are converted to some random objects. So I replace undefined with null in _getNative method.

@mike-north should we do as planed a 3.0 and a 4.0 releases?