Fix: Issue with scaling of dynamics musescore#18860

mike-spa · Aug 16, 2023 · 3766268 · 3766268
1 parent a31e3ca
commit 3766268
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/src/inspector/models/abstractinspectormodel.h b/src/inspector/models/abstractinspectormodel.h
@@ -191,7 +191,7 @@ public slots:
                                    const mu::engraving::EngravingItem* element) const;
 
     notation::INotationStylePtr style() const;
-    bool updateStyleValue(const mu::engraving::Sid& sid, const QVariant& newValue);
+    virtual bool updateStyleValue(const mu::engraving::Sid& sid, const QVariant& newValue);
     QVariant styleValue(const mu::engraving::Sid& sid) const;
 
     notation::INotationUndoStackPtr undoStack() const;

diff --git a/src/inspector/models/notation/dynamics/dynamicsettingsmodel.cpp b/src/inspector/models/notation/dynamics/dynamicsettingsmodel.cpp
@@ -95,6 +95,14 @@ void DynamicsSettingsModel::resetProperties()
     m_frameCornerRadius->resetToDefault();
 }
 
+bool DynamicsSettingsModel::updateStyleValue(const engraving::Sid& sid, const QVariant& newValue)
+{
+    if (sid == engraving::Sid::dynamicsSize) {
+        return AbstractInspectorModel::updateStyleValue(sid, QVariant::fromValue(newValue.toDouble() / 100));
+    }
+    return AbstractInspectorModel::updateStyleValue(sid, newValue);
+}
+
 PropertyItem* DynamicsSettingsModel::avoidBarLines() const
 {
     return m_avoidBarLines;

diff --git a/src/inspector/models/notation/dynamics/dynamicsettingsmodel.h b/src/inspector/models/notation/dynamics/dynamicsettingsmodel.h
@@ -49,6 +49,7 @@ class DynamicsSettingsModel : public AbstractInspectorModel
     void requestElements() override;
     void loadProperties() override;
     void resetProperties() override;
+    bool updateStyleValue(const engraving::Sid& sid, const QVariant& newValue) override;
 
     PropertyItem* avoidBarLines() const;
     PropertyItem* dynamicSize() const;