fix api auth

mike182uk · Nov 19, 2020 · a272fa4 · a272fa4
1 parent 3cefc8a
commit a272fa4
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 # 4.0.0
 
 - Drop support for Node.js `< 10.0.0`
+- Fix GitHub [API autentication deprecation](https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/)
 
 # 3.0.0
 

diff --git a/index.js b/index.js
@@ -27,12 +27,12 @@ async function fetchGists (accessToken) {
       const { body, headers } = await got('https://api.github.com/gists', {
         headers: {
           'User-Agent': 'fetch-gists',
-          accept: 'application/vnd.github.v3+json'
+          accept: 'application/vnd.github.v3+json',
+          Authorization: `token ${accessToken}`
         },
         searchParams: {
           page,
-          per_page: 100,
-          access_token: accessToken
+          per_page: 100
         },
         responseType: 'json'
       })

diff --git a/test.js b/test.js
@@ -147,15 +147,15 @@ function mockGetGistsApiCall (page, body, isLastPage, statusCode = 200) {
 
   const requestHeaders = {
     'User-Agent': 'fetch-gists',
-    accept: 'application/vnd.github.v3+json'
+    accept: 'application/vnd.github.v3+json',
+    Authorization: `token ${ACCESS_TOKEN}`
   }
 
   nock('https://api.github.com', { reqheaders: requestHeaders })
     .get('/gists')
     .query({
-      page: page,
-      per_page: 100,
-      access_token: ACCESS_TOKEN
+      page,
+      per_page: 100
     })
     .reply(statusCode, body, responseHeaders)
 }