Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of decimal input values #41

Merged
merged 2 commits into from
May 18, 2018
Merged

Conversation

vegeta897
Copy link
Contributor

This fixes 1.5 hours parsing as 5 hours, or 1.0 hours as 0 hours

This was presumably working in 2012 with PR #2 but has since broken.

Now decimal values will parse correctly.

Previously, `1.5 hours` would parse as `5 hours`, or `1.0 hours` as `0 hours`

This was presumably working in 2012 with PR mike182uk#2 but has since broken.
@coveralls
Copy link

coveralls commented May 14, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling a3f5260 on vegeta897:patch-1 into e88cf20 on mike182uk:master.

@vegeta897
Copy link
Contributor Author

I could add some tests but I'm not sure where I should fit them in among the whole-number tests, or how extensive it should be with all the different test types.

@mike182uk
Copy link
Owner

Thanks for this @vegeta897

I did not realise that this was broken 😞

I could add some tests but I'm not sure where I should fit them in among the whole-number tests, or how extensive it should be with all the different test types.

Thats no problem, i'll add a couple of tests and make a new release.

Thanks!

@mike182uk mike182uk merged commit e1dcc51 into mike182uk:master May 18, 2018
@mike182uk
Copy link
Owner

Published 5.0.1 with these changes. Thanks 👍

@vegeta897 vegeta897 deleted the patch-1 branch January 12, 2019 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants