Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update For Php 8 compatibitity #1027

Closed
wants to merge 2 commits into from
Closed

Conversation

lfelizari
Copy link

Implemented sugestion from 馃憤 #1007

Implemented sugestion from 馃憤 mike42#1007
@Chris-wg
Copy link

For details on why this is needed see

https://php.watch/versions/8.0/gdimage

"From PHP 8.0 and forward, GD extension uses \GdImage class objects instead of resource s for its underlying data structures."

"Note that all functions in GD extension now returns and expects \GdImage objects instead of resource objects. Unless you explicitly call is_resource() function on return values of GD functions (such as imagecreatefromjpeg() and imagecreate()), this change will be completely trouble-free.

If you are calling is_resource, you will now need to account for the \GdImage object return type too."

@mike42
Copy link
Owner

mike42 commented Mar 8, 2021

Thanks for bringing this to my attention. I've included this with some other changes to get the tests working on PHP 8 (see PR #1042 )

I'll release this as version 4.0 shortly.

@mike42 mike42 closed this Mar 8, 2021
@pajkho
Copy link

pajkho commented May 22, 2022

@mike42 Any update on when V4.0 will be released?

Thanks!

@mike42
Copy link
Owner

mike42 commented May 23, 2022

These commits have been in the development branch for some time, I've re-tested and released it as v4.0 just now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants