Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing 'content-length' header for HTTP responses. #17

Merged
merged 1 commit into from Apr 29, 2012
Merged

add missing 'content-length' header for HTTP responses. #17

merged 1 commit into from Apr 29, 2012

Conversation

jed
Copy link
Contributor

@jed jed commented Apr 29, 2012

according to the README,

Not only does the JSON file get streamed to the HTTP Response it will include an Etag, Last-Modified, Content-Length, and a Content-Type header based on the filed extension.

but only three of these headers are being sent right now; Content-Length is missing.

@mikeal
Copy link
Owner

mikeal commented Apr 29, 2012

how did i miss this!

mikeal added a commit that referenced this pull request Apr 29, 2012
@mikeal
Merge pull request #17 from jed/patch-1
db514b9 
add missing 'content-length' header for HTTP responses.
@mikeal mikeal merged commit db514b9 into mikeal:master Apr 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jed @mikeal