When piping to a response, and an error occurs, end the response #6

merged 1 commit into from Oct 30, 2011


None yet

2 participants

naholyr commented Oct 30, 2011

For the moment the samples in documentation won't work with unexisting files. In those cases, the stream is ended, but not the response.
Plus, as there is no data passed with the "end" event of the stream, there is no clean way to detect why it has been ended and then properly end the response on the other side.
So I propose to end the response directly (as expected from documentation), when such an error occurs.

@mikeal mikeal merged commit 5bad464 into mikeal:master Oct 30, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment