Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adding more explicit error when undefined is passed as uri or options.
- Loading branch information
cea668f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This broke what I thought was a valid use case: setting
options.uri
oroptions.url
to the URI and just doingrequest(options, callback)
. Easy enough to fix, but it's technically a backcompat breakage since that signature worked prior to 2.9.200. See rgrove/node-elastical#19