Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic auth in options #216

Closed
ghost opened this issue Mar 26, 2012 · 4 comments
Closed

Basic auth in options #216

ghost opened this issue Mar 26, 2012 · 4 comments

Comments

@ghost
Copy link

ghost commented Mar 26, 2012

Is it possible to set basic auth in options instead of having it in the url (http://username:password@domain.com)?

Eg.

request.get(uri, {
  username: 'foo',
  password: 'bar'
}, callback);
@jasonmadigan
Copy link

+1

@aseemk
Copy link

aseemk commented Jun 13, 2012

This'd be convenient for us too. =)

@mikeal
Copy link
Member

mikeal commented Jul 25, 2012

i'd prefer this was an option called basicAuth and was

{ basicAuth: ['username', 'password'] }

esamattis added a commit to esamattis/request that referenced this issue Jul 26, 2012
@mmalecki
Copy link
Member

This is implemented as auth option now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants