Updating dependencies #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you should note that this change competely breaks installing request, as tunnel-agent 0.5 is non-existent, 0.3.x is the only available at npm right now (and in git AFAIK) |
Closed
|
Oups, my bad. |
|
Created new pull request #525 |
|
why does this project not have tests and travis ci? |
|
@superjoe30 It does have tests. @mikeal doesn't use any testing framework, but a simple |
|
npm test doesn't run npm install, so the tests didn't find this. this is all fixed. |
|
if you use travis ci, it tells you whether or not merging a pull request will break your tests, and it does run npm install |
|
pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating dependencies to newer version and increase package version.