Request.multipart no longer crashes when header 'Content-type' present #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sent Request.multipart used to crash when options contained a header 'Content-type' which is not purely lowercase. That is because hasHeader is case insensitive and returns true and then the split method gets applied to undefined and crashes the application. One could argue that headers should be spelled using only lowercase. However, mixed case headers used to work with a previous version of request, thus I suggest to incorporate this patch to ensure that legacy code does not suddenly crash after updating request.
mikeal
added a commit
that referenced
this pull request
Nov 26, 2013
Request.multipart no longer crashes when header 'Content-type' present
nylen
pushed a commit
to nylen/request
that referenced
this pull request
Oct 17, 2014
Request.multipart no longer crashes when header 'Content-type' present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request.multipart used to crash when options contained a header 'Content-type' which is not purely lowercase. That is because hasHeader is case-insensitive and returns true, then the split method gets applied to undefined and crashes the application.
One could argue that headers should be spelled using only lowercase. However, mixed case headers used to work with a previous version of request, thus I suggest to incorporate this patch to ensure that legacy code does not suddenly crash after updating request.