Use Cookie.parse #744
Merged
Use Cookie.parse #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using new Cookie(str) doesn't actually set the attributes in the cookie. This is because Cookie takes in an object, and in our case we only accept a string. Using Cookie.parse will return the appropriate properties for the cookie.
|
i'm looking forward this is merged. Cookies are broken until that. |
|
\cc @mikeal |
|
tell me when you're confident enough for a release w/ this. |
nylen
pushed a commit
to nylen/request
that referenced
this pull request
Oct 17, 2014
Use Cookie.parse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
new Cookie(str)doesn't actually set the attributes in the cookie. This is because Cookie takes in an object and in our case we only accept a string. UsingCookie.parsewill set the appropriate properties on the cookie.discussed in #743