Use Cookie.parse #744

Merged
merged 1 commit into from Jan 9, 2014

Projects

None yet

3 participants

@lalitkapoor
Member

Using new Cookie(str) doesn't actually set the attributes in the cookie. This is because Cookie takes in an object and in our case we only accept a string. Using Cookie.parse will set the appropriate properties on the cookie.

discussed in #743

@lalitkapoor lalitkapoor Use Cookie.parse
Using new Cookie(str) doesn't actually set the attributes in the cookie.
This is because Cookie takes in an object, and in our case we only
accept a string. Using Cookie.parse will return the appropriate
properties for the cookie.
41e20a4
@laurentdebricon

i'm looking forward this is merged. Cookies are broken until that.

@lalitkapoor
Member

\cc @mikeal

@mikeal mikeal merged commit 2d7072d into request:master Jan 9, 2014

1 check passed

default The Travis CI build passed
Details
@mikeal
Member
mikeal commented Jan 9, 2014

tell me when you're confident enough for a release w/ this.

@lalitkapoor lalitkapoor deleted the lalitkapoor:should-use-cookie-parse branch Jan 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment