fixes 857 - options object is mutated by calling request #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitkapoor
changed the title
|
I remember there being some reason I mutated the options rather than copy them. But, seeing as though I don't remember why and I completely failed to document it I think we should merge this change. Let's keep an eye on things to make sure we don't see any regressions. Also, it might not be enough to just shallow copy option because some of the values get mutated (headers in particular). |
mikeal
added a commit
that referenced
this pull request
May 7, 2014
…d-by-calling-request fixes 857 - options object is mutated by calling request
|
@mikeal good point about the shallow copy. I could do a deep clone if that's better. or maybe just a |
nylen
pushed a commit
to nylen/request
that referenced
this pull request
Oct 17, 2014
…-mutated-by-calling-request fixes 857 - options object is mutated by calling request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #857.