add option followAllRedirects to follow post/put redirects #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this looks good but it's a big change that i want to spend some time reviewing. i will get to it, i promise, just be patient :) |
|
Sure you've gotta lot of stuff on your plate @mikeal, any chance you have some time to revisit this pull request? This would be very helpful to have. |
|
Sorry, forgot all about this one. This needs a test for maxRedirects added and a line added to the docs to describe the option. Once those are in and the comment by @kitek is addressed it could be merged. |
stolsma
added a commit
to stolsma/request
that referenced
this pull request
Dec 11, 2011
…o 'GET' This behavior is as described by RFC 2616. This change is in addition to issue request#55 and issue request#90 (pull request)
|
Ok, took care of the comments raised in this pull request.
Not sure why the |
mikeal
added a commit
that referenced
this pull request
Feb 4, 2012
add option followAllRedirects to follow post/put redirects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #55.