Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microphone universal mute ui #46

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FotoVerite
Copy link
Contributor

TODO disable all other cards gains and undisable them on toggle.

@vladaspasic
Copy link
Collaborator

Nice work @FotoVerite! Looks great, for me at least :)

I would only suggest that you move the mute button to the menu above. Maybe adding a popover or a button label, with mute/unmute text, would help users figuring out that they can mute the entire page. I think it is a bit confusing to have it the audio tile, as mic mutes the user stream and the volume mutes the master output.

Also when creating the menu button, try using funky to create an element. Pass a state parameter that would set the icon colour, and use the update method to toggle it. It is better to use checked and unchecked callbacks from the checkbox plugin to change those states, docs here: http://semantic-ui.com/modules/checkbox.html#/settings.

@mikeal
Copy link
Owner

mikeal commented Oct 16, 2016

The latest waudio module has a mute() and unmute() method that keep track of the prior volume for us, we should use that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants