Fix time unit for the _now method, and better calculation of the timer delay.
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e method `_now`. The unit is clearly documented by Apple in QA1398: https://developer.apple.com/library/mac/#qa/qa1398/_index.html. I also verified the unit "manually" by comparing elapsed times measured with NSDate and with `_now`.
…en the call to `afterDelay:do:` and the execution of the block that actually schedules the timer.
mikeash
added a commit
that referenced
this pull request
Jul 3, 2013
Fix time unit for the `_now` method, and better calculation of the timer delay.
|
Looks good, thank you. If you feel like starting a test target with your tests, that would be great too. Can figure out proper tests from there, no need for everything to be perfect up front. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While not using directly MABGTimer, I ran into these issues in PARDispatchQueue. I cherry-picked the fixes to bring them back to MABGTimer. It would be nice to have a test target in MABGTimer. I'd be happy to contribute the tests that helped me check that the delay adjustment actually makes a difference.