Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in providing volume metadata with ignore_volume_control #903

Closed
jorbas opened this issue Sep 9, 2019 · 3 comments
Closed

Regression in providing volume metadata with ignore_volume_control #903

jorbas opened this issue Sep 9, 2019 · 3 comments

Comments

@jorbas
Copy link

jorbas commented Sep 9, 2019

Previously, volume metadata would still be sent even if configured to ignore volume control.

Now, no volume metadata is sent if configured to ignore volume control.

I believe this commit broke it by adding a check that config.ignore_volume_control == 0 around the code which outputs volume metadata. You can see that inside this conditional block, there is a check that config.ignore_volume_control == 1, which cannot be true as it is in a block which asserted it was 0!

@mikebrady
Copy link
Owner

Thanks for the post — let me check.

mikebrady added a commit that referenced this issue Sep 10, 2019
@mikebrady
Copy link
Owner

Yes, you are right, and your diagnosis was correct too, thanks. I've fixed the problem and pushed an update into the development branch. Many thanks.

mikebrady added a commit that referenced this issue Sep 10, 2019
Fixes an error whereby the 'pvol' volume metadata was no longer sent if Shairport Sync was configured to ignore volume control information coming from the audio source. Addresses issue #903.
Fixes a compilation error if including the MQTT client.
@mikebrady
Copy link
Owner

Thanks for this contribution. Closing the issue. Please open a new one if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants