Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run workflows on pull requests #1687

Merged
merged 1 commit into from
Jun 10, 2023
Merged

Conversation

yubiuser
Copy link

@yubiuser yubiuser commented Jun 9, 2023

With this PR your workflows (tests) are also triggered on pull requests. So the code is checked already before it reaches development branch.

@yubiuser yubiuser force-pushed the run_tests branch 17 times, most recently from d8e0a7a to 72e740c Compare June 9, 2023 20:24
@yubiuser
Copy link
Author

yubiuser commented Jun 9, 2023

Sorry for the force pushes. Should be fine now. I created a new job within the docker build workflow to build the docker images from PR branches. Took a while how to make this work on PRs from forks.

Signed-off-by: Christian König <ckoenig@posteo.de>
@mikebrady mikebrady merged commit 403792b into mikebrady:development Jun 10, 2023
9 checks passed
@mikebrady
Copy link
Owner

Many thanks -- we'll give it a try!

@yubiuser yubiuser deleted the run_tests branch June 10, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants