Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for raw clause parsing #18

Merged
merged 2 commits into from
Oct 12, 2017

Conversation

hanneskaeufler
Copy link
Contributor

@hanneskaeufler hanneskaeufler commented Oct 12, 2017

This was a bit of fiddling but this exercises the currently uncovered branch as seen here: https://coveralls.io/builds/13692274/source?filename=src%2FCachedBuilder.php#L93

Fixes issue #17

@coveralls
Copy link

coveralls commented Oct 12, 2017

Coverage Status

Coverage increased (+0.7%) to 98.561% when pulling af9d8ea on hanneskaeufler:hk-issue-17 into b7a3cc6 on GeneaLabs:master.

@hanneskaeufler
Copy link
Contributor Author

Scrutinizer failure looked unrelated, so I force pushed to retrigger.

@mikebronner
Copy link
Owner

@hanneskaeufler Woohoo! :) Thanks for working on this :) It appears the unit tests are failing. Yea, I restarted Scrutinizer, and it passed. Will wait for them to finish, will then merge. Keep the TDD magic going! :)

@mikebronner mikebronner self-assigned this Oct 12, 2017
@coveralls
Copy link

coveralls commented Oct 12, 2017

Coverage Status

Coverage increased (+0.7%) to 98.561% when pulling 73de75f on hanneskaeufler:hk-issue-17 into b7a3cc6 on GeneaLabs:master.

@mikebronner mikebronner changed the base branch from master to laravel-5.5 October 12, 2017 19:09
@mikebronner mikebronner merged commit 8fb0532 into mikebronner:laravel-5.5 Oct 12, 2017
@hanneskaeufler
Copy link
Contributor Author

Hehe, my pleasure, love me some testing and I almost got nostalgic about php after a few years of no php work lol 💟

@hanneskaeufler hanneskaeufler deleted the hk-issue-17 branch October 12, 2017 19:14
@mikebronner
Copy link
Owner

mikebronner commented Oct 12, 2017

@hanneskaeufler Make sure you register for Hactoberfest, and if you do the other 3 issues (each as its own pull request), you will already be eligible for your t-shirt! :)

https://hacktoberfest.digitalocean.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants