-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit test for raw clause parsing #18
Add unit test for raw clause parsing #18
Conversation
Laravel 5.5
af9d8ea
to
73de75f
Compare
Scrutinizer failure looked unrelated, so I force pushed to retrigger. |
@hanneskaeufler Woohoo! :) Thanks for working on this :) It appears the unit tests are failing. Yea, I restarted Scrutinizer, and it passed. Will wait for them to finish, will then merge. Keep the TDD magic going! :) |
Hehe, my pleasure, love me some testing and I almost got nostalgic about php after a few years of no php work lol 💟 |
@hanneskaeufler Make sure you register for Hactoberfest, and if you do the other 3 issues (each as its own pull request), you will already be eligible for your t-shirt! :) |
This was a bit of fiddling but this exercises the currently uncovered branch as seen here: https://coveralls.io/builds/13692274/source?filename=src%2FCachedBuilder.php#L93
Fixes issue #17