Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix model connection for SQLite tests #270

Merged
merged 1 commit into from
Jul 20, 2019
Merged

Fix model connection for SQLite tests #270

merged 1 commit into from
Jul 20, 2019

Conversation

anderson-comvex
Copy link
Contributor

@anderson-comvex anderson-comvex commented Jul 12, 2019 •
edited
Loading

While running integration and feature tests using SQLite driver and the query is not completed initialized in a multitenant scenario and for example the output of $this->query->toSql() will be select * or 1, this will fallback to the default connection instead of using the proper model connection.

Fix #272

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.644% when pulling 78679d5 on anderson-comvex:master into 9387aae on GeneaLabs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.644% when pulling 78679d5 on anderson-comvex:master into 9387aae on GeneaLabs:master.

@mikebronner mikebronner merged commit fd6d007 into mikebronner:master Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHPUnit SQLite Multiple connections, missmatch cache key
3 participants
@anderson-comvex @coveralls @mikebronner