Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken limit test #330

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Fix broken limit test #330

merged 1 commit into from
Apr 10, 2020

Conversation

dmason30
Copy link
Contributor

No description provided.

@dmason30
Copy link
Contributor Author

Is there a good reason for phpunit config to have stopOnFailure=true ? I have always used it as false since it hides other failing tests especially on CI tools?

@dmason30 dmason30 changed the title Fix broken limit text Fix broken limit test Apr 10, 2020
@mikebronner
Copy link
Owner

True, but it makes it much easier for local development. If there is an error in the CI, I generally never look at all the errors, but only the fact that it errored. Then I go to my local machine and run the tests, failing at the first error. Often subsequent errors are artifacts of the first one.

@mikebronner mikebronner merged commit 3a7c951 into mikebronner:master Apr 10, 2020
@dmason30 dmason30 deleted the fix-limit-test branch April 10, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants