Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add a fudge factor #106

Merged
merged 1 commit into from
Apr 15, 2020
Merged

fix: Add a fudge factor #106

merged 1 commit into from
Apr 15, 2020

Conversation

mikebryant
Copy link
Owner

@mikebryant mikebryant commented Apr 15, 2020

The reversed code isn't a perfect match for ARM 32-bit floating point assembly. This should allow us to cope with things that are a little out of range due to floating point weirdness

I've checked these issues, and this allows them to compute a pattern:

Fixes #74

Fixes #96

Fixes #63

Fixes #60

Fixes #40

The reversed code isn't a perfect match for ARM 32-bit floating point assembly. This should allow us to cope with things that are a little out of range due to floating point weirdness
@mikebryant mikebryant merged commit 0634b5e into master Apr 15, 2020
@mikebryant mikebryant deleted the fudge-factor branch April 15, 2020 13:14
@ZZZZzzzzac
Copy link

ZZZZzzzzac commented Apr 16, 2020

isn't 5 too large? if it's float point issue there should be only 1 or 2 missing
or let user input fudge factor, 5 makes it's hard to rule out some subpattern

@mikebryant
Copy link
Owner Author

Tried 1 at first - when I was going through the issues of people reporting stuff it needed more to cover all the cases.

I suspect the issue is more with the rates, where multiple small floating point errors accumulate to make a larger difference in the final number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants