feat: Implements a more true to game code intceil calculation #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces all instances of
Math.floor()
andMath.ceil()
with a calculation that more closely matches the C++ implementation in game. In the extracted code, the all values are passed through a functionintceil()
which is implemented as...In C++ the behaviour of casting to an int results in a truncated value, not a rounded value. As such, there are situations where using JavaScript's
Math.floor()
orMath.ceil()
can result in a value that is off by one. By usingMath.trunc()
, we can more closely represent the C++ behaviour.I know we already have reports of calculation issues, and there is a feeling that having a wider net of possible values can reduce the number of failed predictions, but I personally feel the wider net makes it more difficult to diagnose potential problems in this app's calculations. I feel it would be best to represent the in-game calculation as closely as possible.
Open to discussion of course!
Closes #47