Skip to content

Commit

Permalink
Merge pull request #38 from mikebryant/wip-37
Browse files Browse the repository at this point in the history
Fix django.contrib.admin urls on Django 1.10. Fixes #37
  • Loading branch information
mikebryant committed Dec 21, 2016
2 parents 563e0bb + 9c22522 commit 725d601
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 2 deletions.
4 changes: 2 additions & 2 deletions django_autoconfig/contrib/admin/urls.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from django.conf.urls import include
from django.conf.urls import include, url
try:
from django.conf.urls import patterns
except ImportError:
Expand All @@ -8,5 +8,5 @@ def patterns(_, *args):

admin.autodiscover()
urlpatterns = patterns('',
('', include(admin.site.urls)),
url('', include(admin.site.urls)),
)
Empty file.
5 changes: 5 additions & 0 deletions django_autoconfig/tests/app_contrib_admin/autoconfig.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
SETTINGS = {
'INSTALLED_APPS': [
'django.contrib.admin',
],
}
17 changes: 17 additions & 0 deletions django_autoconfig/tests/test_autoconfig.py
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,23 @@ def test_url_prefixes(self):
)
resolve('/flibble/index/', urlconf=self)

def test_contrib_admin(self):
'''
Test that our django.contrib.admin dependencies work.
'''
settings_dict = {
'INSTALLED_APPS': [
'django_autoconfig.tests.app_contrib_admin',
],
}

autoconfig.configure_settings(settings_dict)
with test.utils.override_settings(**settings_dict):
self.create_urlconf(
list(settings_dict['INSTALLED_APPS']) + list(settings_dict['AUTOCONFIG_EXTRA_URLS']),
)
resolve('/django-autoconfig.contrib.admin/', urlconf=self)


@test.utils.override_settings(ROOT_URLCONF='django_autoconfig.tests.index_view_urlconf')
class IndexViewTestCase(test.TestCase):
Expand Down

0 comments on commit 725d601

Please sign in to comment.