Skip to content
This repository has been archived by the owner on Feb 25, 2021. It is now read-only.

Carthage Support #70

Merged
merged 3 commits into from
May 5, 2016
Merged

Carthage Support #70

merged 3 commits into from
May 5, 2016

Conversation

hardikdevios
Copy link
Contributor

@hardikdevios hardikdevios commented May 5, 2016

  1. Merge it.
  2. Bump the Version (New Tag)
  3. Cheers buddy

@hardikdevios hardikdevios mentioned this pull request May 5, 2016
@mikebuss
Copy link
Owner

mikebuss commented May 5, 2016

Thanks for the awesome work @hardikdevios! After this is merged I will add a version tag so this is official, then update this ticket.

@mikebuss mikebuss merged commit acff6ed into mikebuss:develop May 5, 2016
@mikebuss
Copy link
Owner

mikebuss commented May 5, 2016

@hardikdevios I pushed a new version (2.0.1) that includes this. I had to move the MTBBarcode.h file to the Classes directory in order for CocoaPods to work with this change - if this file is in the Project folder, it won't be included with the Pod, and the #import in MTBBarcodeScanner.h will throw an error.

Can you verify this works on your end?

@mikebuss
Copy link
Owner

mikebuss commented May 5, 2016

@hardikdevios scratch that, removing the import from MTBBarcodeScanner.h fixed the CocoaPods issue. I've released v2.0.2 that is working with Carthage on my end. Please let me know if you encounter any issues.

Thanks again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants