refactor: make drawPdf function less opinionated #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think drawPdf should leave the styling and scale of the pdf to the hook caller. Setting the canvas height and width is fine for displaying the PDF since the canvas is taking on the height and width of the PDF. The canvas element that uses the hook can be styled in any fashion through class name or style. The default scale of 1 is acceptable for any screen. Making the caller of the hook responsible for the scale allows for better usability of the hook in many cases.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This fixes the scale issue and takes into account the device dpi. Before the scale was only applied to the pdfjs generated viewport. This applies the scale to actual canvas instead. Referenced from this SOF: https://stackoverflow.com/a/5306929/4771642
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think drawPdf should leave the styling and scale of the pdf to the hook caller.
Setting the canvas height and width is fine for displaying the PDF since the canvas is taking on the height and width of the PDF. The canvas element that uses the hook can be styled in any fashion through class name or style.
This also provides a solution to #405.
Before this change, the scale was only applied to the pdfjs-generated viewport, this instead applies the scale to the canvas. Referenced from this SOF: https://stackoverflow.com/a/5306929/4771642