Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS X client breaks on apostrophe #52

Open
zannalov opened this issue Sep 4, 2012 · 2 comments
Open

OS X client breaks on apostrophe #52

zannalov opened this issue Sep 4, 2012 · 2 comments

Comments

@zannalov
Copy link

zannalov commented Sep 4, 2012

I've found that if the host machine has a directory with an apostrophe, the OS X client will only show the name up to (but not including) the apostrophe in the mounted filesystem. This means when you try to enter the directory, OS X requests the truncated name (which doesn't exist on the server) and gets an access error. For example, a directory named "I'm sure this will work" shows up on the Mac as "I". Apparently apostrophes are not encoded by encodeURI, and OS X needs them to be encoded.

zannalov added a commit to zannalov/jsDAV that referenced this issue Sep 4, 2012
…y explicitly encoding apostrophes as well.
zannalov added a commit to zannalov/jsDAV that referenced this issue Sep 6, 2012
…ers break the OS X client as well. Changed my approach to completely escape all path fragments, and this seems to be working for every file I throw at it. Fixes mikedeboer#52
zannalov added a commit to zannalov/jsDAV that referenced this issue Sep 6, 2012
… marks while fixing most other characters. Forgot to go back and test the original problem. This has been tested with quote marks, double quote marks, ampersands, dashes, spaces, etc. Fixes mikedeboer#52
@thieso2
Copy link

thieso2 commented May 23, 2013

any explanation why this is not merged yet? Is the fix invalid or just missing some tests?

@tiff
Copy link

tiff commented Jun 18, 2013

I can reproduce this with OSX Mountain Lion and latest master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants