Fixes jashkenas#2274 -- allow @variables as loop variables

mikedemarais · Apr 24, 2012 · 4fc9a34 · 4fc9a34
1 parent c06487c
commit 4fc9a34
Show file tree

Hide file tree

Showing 4 changed files with 205 additions and 105 deletions.
diff --git a/lib/coffee-script/grammar.js b/lib/coffee-script/grammar.js
diff --git a/lib/coffee-script/parser.js b/lib/coffee-script/parser.js
diff --git a/src/grammar.coffee b/src/grammar.coffee
@@ -443,6 +443,7 @@ grammar =
   # This enables support for pattern matching.
   ForValue: [
     o 'Identifier'
+    o 'ThisProperty'
     o 'Array',                                  -> new Value $1
     o 'Object',                                 -> new Value $1
   ]

diff --git a/test/comprehensions.coffee b/test/comprehensions.coffee
@@ -499,3 +499,14 @@ test "#2007: Return object literal from comprehension", ->
   eq 2, y.length
   eq 1, y[0].x
   eq 0, y[1].x
+
+test "#2274: Allow @values as loop variables", ->
+  obj = {
+    item: null
+    method: ->
+      for @item in [1, 2, 3]
+        null
+  }
+  eq obj.item, null
+  obj.method()
+  eq obj.item, 3