#607 Fix string value with spaces error #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @djajcevic! |
|
Just a fyi in case you (hopefully) contribute more, I've moved the test case to operator_value_test.go |
|
@mikefarah should this be in Milestone 4.1.0 or you are planning to make a bug fix release (4.0.1). |
|
Should hopefully release 4.1.0 tmrw along with other fixes, otherwise it will have to wait till after christmas. |
|
If you want, I can release 4.0.1 :) (if by following instructions you wrote I have permissions) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #607
I've added one more test that produces documentation entry.
The reason behind excluding space inside
"..."is unknown to me, but since all tests are passing I think we are good. If needed, I can go a bit more into implementation to figure out a better solution.By examining https://github.com/timtadh/lexmachine#adding-a-pattern I found that it is safe to remove that space from the regex exclude group since
lexer.Add([]byte(), token("SPACE"))is not an option for YQ.