allow using the same camera model with different finders #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the use case here is that a single camera is used in multiple finders. When that happens we want the same parameters to be used when calibrating the camera intrinsics, but we need a different camera name to differentiate which observation should be associated with which error block (this is especially true for the upcoming robot/plane finder)
mkaca
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the use case here is that a single camera is used in multiple
finders. When that happens we want the same parameters to
be used when calibrating the camera intrinsics, but we
need a different camera name to differentiate which
observation should be associated with which error block
(this is especially true for the upcoming robot/plane
finder)