Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add finder for 2d checkerboard #152

Merged
merged 3 commits into from May 16, 2023
Merged

Add finder for 2d checkerboard #152

merged 3 commits into from May 16, 2023

Conversation

mikeferguson
Copy link
Owner

This is the first step towards completing #41

  • Refactors checkerboard finder to be templated on data type.
  • Uses template specialization to make 2d and 3d variants.
  • Updates test to load both variants.

This was tested on the UBR-1 using this configuration: mikeferguson/ubr_reloaded@06587cc

@mikeferguson
Copy link
Owner Author

I've now tested all the way through calibration - so this finder is definitely working.

@mikeferguson mikeferguson merged commit 6fb336a into ros2 May 16, 2023
1 check passed
@mikeferguson mikeferguson deleted the 2d_finder branch May 16, 2023 21:41
mikeferguson added a commit that referenced this pull request May 17, 2023
this is a backport of #152 to ROS1
mikeferguson added a commit that referenced this pull request May 17, 2023
Second part of #41, adds error block to use data from #152
mikeferguson added a commit that referenced this pull request May 24, 2023
this is a backport of #152 to ROS1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant