Kinetic: ceres-solver broken in 16.04

[mikeferguson]

https://bugs.launchpad.net/ubuntu/+source/ceres-solver/+bug/1595692

[k-okada]

@mikeferguson It seems ceres-solver is available on package.ros.org, so now it's ok to release fetch_gazebo in to kinetic.

It seems the all rostest has been passed

k-okada@p51s:~/catkin_ws/ws_fetch/build/robot_calibration$ make run_tests
Scanning dependencies of target clean_test_results_robot_calibration
Removing test result files from '/home/k-okada/catkin_ws/ws_fetch/build/robot_calibration/test_results/robot_calibration'
- removing '/home/k-okada/catkin_ws/ws_fetch/build/robot_calibration/test_results/robot_calibration/rosunit-optimization_param_tests.xml'
- removing '/home/k-okada/catkin_ws/ws_fetch/build/robot_calibration/test_results/robot_calibration/MISSING-gtest-calibration_offset_parser_tests.xml'
- removing '/home/k-okada/catkin_ws/ws_fetch/build/robot_calibration/test_results/robot_calibration/rostest-test_chain_manager_tests.xml'
- removing '/home/k-okada/catkin_ws/ws_fetch/build/robot_calibration/test_results/robot_calibration/MISSING-gtest-rotation_tests.xml'
- removing '/home/k-okada/catkin_ws/ws_fetch/build/robot_calibration/test_results/robot_calibration/rostest-test_optimization_param_tests.xml'
- removing '/home/k-okada/catkin_ws/ws_fetch/build/robot_calibration/test_results/robot_calibration/rosunit-chain_manager_tests.xml'
- removing '/home/k-okada/catkin_ws/ws_fetch/build/robot_calibration/test_results/robot_calibration/rosunit-error_block_tests.xml'
- removing '/home/k-okada/catkin_ws/ws_fetch/build/robot_calibration/test_results/robot_calibration/rostest-test_error_block_tests.xml'
[  0%] Built target clean_test_results_robot_calibration
[  8%] Built target gtest
[ 50%] Built target robot_calibration
[ 58%] Built target chain_manager_tests
[ 66%] Built target gtest_main
[ 75%] Built target rotation_tests
[ 83%] Built target optimization_param_tests
[ 91%] Built target calibration_offset_parser_tests
[100%] Built target error_block_tests
[100%] Built target tests
Scanning dependencies of target _run_tests_robot_calibration_rostest_test_error_block_tests.test
-- run_tests.py: execute commands
  /opt/ros/kinetic/share/rostest/cmake/../../../bin/rostest --pkgdir=/home/k-okada/catkin_ws/ws_fetch/src/robot_calibration/robot_calibration --package=robot_calibration --results-filename test_error_block_tests.xml --results-base-dir /home/k-okada/catkin_ws/ws_fetch/build/robot_calibration/test_results /home/k-okada/catkin_ws/ws_fetch/src/robot_calibration/robot_calibration/test/error_block_tests.test 
... logging to /home/k-okada/.ros/log/rostest-p51s-3549.log
[ROSUNIT] Outputting test results to /home/k-okada/catkin_ws/ws_fetch/build/robot_calibration/test_results/robot_calibration/rostest-test_error_block_tests.xml
testerror_block_tests ... ok

[ROSTEST]-----------------------------------------------------------------------

[robot_calibration.rosunit-error_block_tests/error_blocks_maxwell][passed]

SUMMARY
 * RESULT: SUCCESS
 * TESTS: 1
 * ERRORS: 0
 * FAILURES: 0

rostest log file is in /home/k-okada/.ros/log/rostest-p51s-3549.log
-- run_tests.py: verify result "/home/k-okada/catkin_ws/ws_fetch/build/robot_calibration/test_results/robot_calibration/rostest-test_error_block_tests.xml"
[100%] Built target _run_tests_robot_calibration_rostest_test_error_block_tests.test
Scanning dependencies of target _run_tests_robot_calibration_rostest_test_chain_manager_tests.test
-- run_tests.py: execute commands
  /opt/ros/kinetic/share/rostest/cmake/../../../bin/rostest --pkgdir=/home/k-okada/catkin_ws/ws_fetch/src/robot_calibration/robot_calibration --package=robot_calibration --results-filename test_chain_manager_tests.xml --results-base-dir /home/k-okada/catkin_ws/ws_fetch/build/robot_calibration/test_results /home/k-okada/catkin_ws/ws_fetch/src/robot_calibration/robot_calibration/test/chain_manager_tests.test 
... logging to /home/k-okada/.ros/log/rostest-p51s-3638.log
[ROSUNIT] Outputting test results to /home/k-okada/catkin_ws/ws_fetch/build/robot_calibration/test_results/robot_calibration/rostest-test_chain_manager_tests.xml
testchain_manager_tests ... ok

[ROSTEST]-----------------------------------------------------------------------

[robot_calibration.rosunit-chain_manager_tests/test_rosparam_loading][passed]

SUMMARY
 * RESULT: SUCCESS
 * TESTS: 1
 * ERRORS: 0
 * FAILURES: 0

rostest log file is in /home/k-okada/.ros/log/rostest-p51s-3638.log
-- run_tests.py: verify result "/home/k-okada/catkin_ws/ws_fetch/build/robot_calibration/test_results/robot_calibration/rostest-test_chain_manager_tests.xml"
[100%] Built target _run_tests_robot_calibration_rostest_test_chain_manager_tests.test
Scanning dependencies of target _run_tests_robot_calibration_rostest_test_optimization_param_tests.test
-- run_tests.py: execute commands
  /opt/ros/kinetic/share/rostest/cmake/../../../bin/rostest --pkgdir=/home/k-okada/catkin_ws/ws_fetch/src/robot_calibration/robot_calibration --package=robot_calibration --results-filename test_optimization_param_tests.xml --results-base-dir /home/k-okada/catkin_ws/ws_fetch/build/robot_calibration/test_results /home/k-okada/catkin_ws/ws_fetch/src/robot_calibration/robot_calibration/test/optimization_param_tests.test 
... logging to /home/k-okada/.ros/log/rostest-p51s-3814.log
[ROSUNIT] Outputting test results to /home/k-okada/catkin_ws/ws_fetch/build/robot_calibration/test_results/robot_calibration/rostest-test_optimization_param_tests.xml
testoptimization_param_tests ... ok

[ROSTEST]-----------------------------------------------------------------------

[robot_calibration.rosunit-optimization_param_tests/test_rosparam_loading][passed]

SUMMARY
 * RESULT: SUCCESS
 * TESTS: 1
 * ERRORS: 0
 * FAILURES: 0

rostest log file is in /home/k-okada/.ros/log/rostest-p51s-3814.log
-- run_tests.py: verify result "/home/k-okada/catkin_ws/ws_fetch/build/robot_calibration/test_results/robot_calibration/rostest-test_optimization_param_tests.xml"
[100%] Built target _run_tests_robot_calibration_rostest_test_optimization_param_tests.test
Scanning dependencies of target _run_tests_robot_calibration_rostest
[100%] Built target _run_tests_robot_calibration_rostest
Scanning dependencies of target _run_tests_robot_calibration_gtest_rotation_tests
-- run_tests.py: execute commands
  /home/k-okada/catkin_ws/ws_fetch/devel/.private/robot_calibration/lib/robot_calibration/rotation_tests --gtest_output=xml:/home/k-okada/catkin_ws/ws_fetch/build/robot_calibration/test_results/robot_calibration/gtest-rotation_tests.xml
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from RotationTests
[ RUN      ] RotationTests.rotationsOK
[       OK ] RotationTests.rotationsOK (1 ms)
[----------] 1 test from RotationTests (1 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (1 ms total)
[  PASSED  ] 1 test.
-- run_tests.py: verify result "/home/k-okada/catkin_ws/ws_fetch/build/robot_calibration/test_results/robot_calibration/gtest-rotation_tests.xml"
[100%] Built target _run_tests_robot_calibration_gtest_rotation_tests
Scanning dependencies of target _run_tests_robot_calibration_gtest_calibration_offset_parser_tests
-- run_tests.py: execute commands
  /home/k-okada/catkin_ws/ws_fetch/devel/.private/robot_calibration/lib/robot_calibration/calibration_offset_parser_tests --gtest_output=xml:/home/k-okada/catkin_ws/ws_fetch/build/robot_calibration/test_results/robot_calibration/gtest-calibration_offset_parser_tests.xml
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from CalibrationOffsetParserTests
[ RUN      ] CalibrationOffsetParserTests.test_urdf_update
[       OK ] CalibrationOffsetParserTests.test_urdf_update (0 ms)
[----------] 1 test from CalibrationOffsetParserTests (0 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (0 ms total)
[  PASSED  ] 1 test.
-- run_tests.py: verify result "/home/k-okada/catkin_ws/ws_fetch/build/robot_calibration/test_results/robot_calibration/gtest-calibration_offset_parser_tests.xml"
[100%] Built target _run_tests_robot_calibration_gtest_calibration_offset_parser_tests
Scanning dependencies of target _run_tests_robot_calibration_gtest
[100%] Built target _run_tests_robot_calibration_gtest
Scanning dependencies of target _run_tests_robot_calibration
[100%] Built target _run_tests_robot_calibration
Scanning dependencies of target run_tests
[100%] Built target run_tests
k-okada@p51s:~/catkin_ws/ws_fetch/build/robot_calibration$ catkin_test_results 
Summary: 8 tests, 0 errors, 0 failures, 0 skipped

Some of gtest is failing, but it they are also failing on indigo too.

Running tests...
Test project /home/k-okada/catkin_ws/ws_fetch/build/robot_calibration
    Start 1: _ctest_robot_calibration_gtest_calibration_offset_parser_tests
1/5 Test #1: _ctest_robot_calibration_gtest_calibration_offset_parser_tests ........***Failed    0.05 sec
    Start 2: _ctest_robot_calibration_gtest_rotation_tests
2/5 Test #2: _ctest_robot_calibration_gtest_rotation_tests .........................***Failed    0.04 sec
    Start 3: _ctest_robot_calibration_rostest_test_chain_manager_tests.test
3/5 Test #3: _ctest_robot_calibration_rostest_test_chain_manager_tests.test ........   Passed    1.63 sec
    Start 4: _ctest_robot_calibration_rostest_test_optimization_param_tests.test
4/5 Test #4: _ctest_robot_calibration_rostest_test_optimization_param_tests.test ...   Passed    1.43 sec
    Start 5: _ctest_robot_calibration_rostest_test_error_block_tests.test
5/5 Test #5: _ctest_robot_calibration_rostest_test_error_block_tests.test ..........   Passed    1.34 sec

60% tests passed, 2 tests failed out of 5

Total Test time (real) =   4.48 sec

The following tests FAILED:
	  1 - _ctest_robot_calibration_gtest_calibration_offset_parser_tests (Failed)
	  2 - _ctest_robot_calibration_gtest_rotation_tests (Failed)
Errors while running CTest
Makefile:115: recipe for target 'test' failed

If we'd like to remove warnings, we need to fix.

diff --git a/robot_calibration/CMakeLists.txt b/robot_calibration/CMakeLists.txt
index 013042b..2873401 100644
--- a/robot_calibration/CMakeLists.txt
+++ b/robot_calibration/CMakeLists.txt
@@ -55,7 +55,7 @@ catkin_package(
     tf
   DEPENDS
     Boost
-    Ceres
+    CERES
     orocos_kdl
   LIBRARIES
     robot_calibration
@@ -85,7 +85,6 @@ target_link_libraries(robot_calibration ${Boost_LIBRARIES}
                                         ${CERES_LIBRARIES}
                                         ${tinyxml_LIBRARIES}
                                         ${orocos_kdl_LIBRARIES})
-add_dependencies(robot_calibration robot_calibration_msgs_gencpp)
 
 add_executable(calibrate src/calibrate.cpp)
 target_link_libraries(calibrate robot_calibration

[mikeferguson]

ros/rosdistro#16966