Allow some time to get TFs in plane_finder #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM -- although I think my comment on line 128 is actually the "proper" fix for the TF issue (not sure why I didn't move it to a class member... I'll take a closer look at that). I'll cherry pick this to Melodic -- I'm no longer really updating the indigo-devel at this point, since it has < 1 year of life and most people are porting robots over to Kinetic or Melodic. Thanks! |
|
BTW -- can I ask which robot you are on? |
|
@mikeferguson platform called MOnarCH, with a custom arm. We will be at RoboCup, @home league! Thank you for making this open source. |
|
@guilhermelawless awesome! Good luck at the RoboCup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a 1s sleep after creating the tfBuffer so we can listen to TFs. Previously, I always had an error message for the first point because no TF arrived (there are no sleeps in between).
Do not allow to continue for that point when there is a TF Exception
Send some information about the point cloud data, similar to "Found the checkboard", as user feedback.
PS: Sorry, don't know how to handle changes common to multiple branches with PRs, we are working in kinetic.