Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make checkerboards actually generic #63

Merged
merged 4 commits into from
Jul 7, 2018
Merged

Make checkerboards actually generic #63

merged 4 commits into from
Jul 7, 2018

Conversation

mikeferguson
Copy link
Owner

  • Revert fetch-specific checkerboard orientation hack
  • Add parameters for loading initial pose of checkerboard
  • Add visualization tool

@mikeferguson
towards working checkerboards
170dcc7 
* unhack the checkerboard finder, so that points are in x/y only
* add free_frames_initial_values parameter for setting initial
  offset of checkerboard frame
@mikeferguson
break out load_bag function for reuse
9fda4d2
@mikeferguson
add tool to visualize bagfile
95bd3a7
@mikeferguson
fix build in kinetic
5a0b2cc
@mikeferguson
Copy link
Owner Author

mikeferguson commented Jul 7, 2018 •
edited
Loading

After merge, we need to document:

  • how to use the new free_frames_initial_values parameter
  • how to determine the initial values for checkerboard if unsure (by setting nothing else as free params)
    • that initial values are RPY, but outputs are axis-magnitude. How to use conversion tool
  • how to use visualization tool

@mikeferguson
Copy link
Owner Author

Fixes #17

@mikeferguson mikeferguson merged commit 60c8677 into master Jul 7, 2018
@mikeferguson mikeferguson deleted the checkerboards_that_work branch July 7, 2018 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mikeferguson