Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Brent's method with derivatives in Univariate.hs, proposed a type ... #52

Closed
wants to merge 1 commit into from

Conversation

ehlemur-zz
Copy link
Contributor

In this commit I

  • Added Brent's method with derivatives in src/HLearn/Optimization/Univariate.hs
  • Fixed what I think is a bug in Brent's method

To make it compile I had to

  • Add a type for lineSearchBrent in Multivariate.hs
  • Comment line 154 in hlearn.cabal, since it requires a deleted file (src/HLearn/Optimization/Common.hs)

Please let me know what you think

…pe for lineSearchBrent in Multivariate.hs and commented line 154 in hlearn.cabal, since it requires a deleted file
@mikeizbicki mikeizbicki closed this Apr 6, 2015
@mikeizbicki
Copy link
Owner

Fix the style issue and I'll merge the commit.

If you send me a reference to the submodular optimization algorithm you want to implement, I'll take a look and make sure things should go smoothly for you.

@ehlemur-zz
Copy link
Contributor Author

Ok, I'll redirect these mails to my thesis advisor, so he knows about this
process.

On Mon, Apr 6, 2015 at 6:07 PM, Mike Izbicki notifications@github.com
wrote:

Fix the style issue and I'll merge the commit.

If you send me a reference to the submodular optimization algorithm you
want to implement, I'll take a look and make sure things should go smoothly
for you.


Reply to this email directly or view it on GitHub
#52 (comment).

Edward Lesmes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants