Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in fipio #19

Closed
mikejohnson51 opened this issue Dec 17, 2021 · 8 comments
Closed

Bring in fipio #19

mikejohnson51 opened this issue Dec 17, 2021 · 8 comments

Comments

@mikejohnson51
Copy link
Owner

I would like to ping @program-- to work with me on replacing USAboudnaries data with fipio.

@mikejohnson51 mikejohnson51 changed the title Bring in folio Bring in fipio Dec 17, 2021
@program--
Copy link
Contributor

Hey @mikejohnson51! I'm finishing up 1.1.0 for fipio right now (going to forgo spress for now, at the expense of ZCTA geometry resolution) and am planning to push it up to CRAN today or tomorrow. I'll open a PR as soon as I merge fipio 1.1.0 in its repo -- sound good?

@mikejohnson51
Copy link
Owner Author

sounds great! Hey, so how would you do the following in fipio?

AOI = AOI::aoi_get(state = "OH", county = 'all')

This type of request is the one possible limitation I have seen to this integration...

@program--
Copy link
Contributor

See here: https://github.com/program--/fipio/blob/eba5eba635c144c88ad4c0bbbf3f16b2feb9c089/R/fipio.R#L12-L47
This feature isn't up on CRAN yet but will be

I'm going to add "all" and "conus" options just for AOI 😄

@program--
Copy link
Contributor

@mikejohnson51 I submitted fipio 1.1.0 yesterday, but I had to resubmit again due to some URLs in the README that needed to be fixed to their redirects... I missed the window by a day as the CRAN submission team is returning this message on submission:

The submission team is on vacation till Jan 3, 2022.
During this time the submission of packages is not possible.
Sorry for any inconvenience.

😞 I'll still work on the AOI PR but this is going to push it back till Jan 3rd.

@mikejohnson51
Copy link
Owner Author

Not a problem! Thanks @program-- :)

@mikejohnson51
Copy link
Owner Author

I believe this is closed? @program--

@program--
Copy link
Contributor

@mikejohnson51 I think so 😄

@mikejohnson51
Copy link
Owner Author

me too. Closed with 894af3a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants