Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Region query lost with fipio migration #22

Closed
mikejohnson51 opened this issue Apr 11, 2022 · 2 comments
Closed

Region query lost with fipio migration #22

mikejohnson51 opened this issue Apr 11, 2022 · 2 comments

Comments

@mikejohnson51
Copy link
Owner

example:

AOI::aoi_get(state = "south", county = "all")
#> Error: State, county pair(s) not found

Created on 2022-04-11 by the reprex package (v2.0.1)

@mikejohnson51
Copy link
Owner Author

@program-- the issue here is that a "bad" state now returns an empty data.frame rather then NULL as before. Easy to fix in AOI but is this what you want/expect?

fip_meta(state = "south")
#> Simple feature collection with 1 feature and 14 fields (with 1 geometry empty)
#> Geometry type: GEOMETRY
#> Dimension:     XY
#> Bounding box:  xmin: NA ymin: NA xmax: NA ymax: NA
#> Geodetic CRS:  WGS 84
#>   state_region state_division feature_code state_name state_abbr name fip_class tiger_class
#> 1           NA             NA         <NA>       <NA>       <NA> <NA>      <NA>        <NA>
#>   combined_area_code metropolitan_area_code functional_status land_area water_area fip_code
#> 1                 NA                   <NA>              <NA>        NA         NA     <NA>
#>                   geometry
#> 1 GEOMETRYCOLLECTION EMPTY

@program--
Copy link
Contributor

This is intended behavior, as it ensures vectorized calls are the same length as the parameters 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants