Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ggentropy: add "portable" path using /dev/urandom #18

Closed
wants to merge 1 commit into from

Conversation

alarixnia
Copy link
Contributor

Needed on Solaris and so on.

@mikejsavage
Copy link
Owner

seems like it would be better to use arc4random on solaris

Also I'm hesitant to add a catch all. ggentropy already has code paths for platforms that I never have and never will actually test it on and Solaris is another like that. I'd prefer to at least restrict it to platforms I've skimmed the manpages for

@alarixnia
Copy link
Contributor Author

we still support solaris 10 in pkgsrc which lacks such a function, among other less commom unix-likes, so i'd like to keep patching this in.

@mikejsavage
Copy link
Owner

mikejsavage commented Jan 29, 2022 via email

@curiositycasualty
Copy link
Contributor

Add Debian 8 to the list of platforms lacking SYS_getrandom:

gcc -I/tmp/work/openssl-1.1.1m/include -std=gnu99 -fPIC -I/tmp/build/usr/local/openresty/luajit/include/luajit-2.1 -c src/ggentropy.c -o src/ggentropy.o
src/ggentropy.c: In function 'ggentropy':
src/ggentropy.c:59:20: error: 'SYS_getrandom' undeclared (first use in this function)
  int ok = syscall( SYS_getrandom, buf, n, 0 );
                    ^
src/ggentropy.c:59:20: note: each undeclared identifier is reported only once for each function it appears in

Error: Failed installing dependency: https://luarocks.org/bcrypt-2.2-1.src.rock - Build error: Failed compiling object src/ggentropy.o

@mikejsavage
Copy link
Owner

Sorry, but I have no interest in supporting Solaris from 2005 even if it is still under LTS.

Likewise Debian 8 is on a second level of LTS with the underlying kernel EOL'd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants