Skip to content

Commit

Permalink
Remove RSPEC deprecation warning
Browse files Browse the repository at this point in the history
  • Loading branch information
Mikel Lindsaar committed Nov 19, 2012
1 parent d42fda6 commit 6fcf8e7
Showing 1 changed file with 29 additions and 29 deletions.
58 changes: 29 additions & 29 deletions spec/mail/network_spec.rb
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class MyRetriever; def initialize(settings); end; end
:password => nil, :password => nil,
:authentication => nil, :authentication => nil,
:enable_starttls_auto => true } :enable_starttls_auto => true }

retriever_method :pop3, { :address => "localhost", retriever_method :pop3, { :address => "localhost",
:port => 110, :port => 110,
:user_name => nil, :user_name => nil,
Expand All @@ -27,14 +27,14 @@ class MyRetriever; def initialize(settings); end; end
end end


describe "default delivery and retriever methods" do describe "default delivery and retriever methods" do

it "should set the delivery method" do it "should set the delivery method" do
Mail.defaults do Mail.defaults do
delivery_method :smtp delivery_method :smtp
end end
Mail.delivery_method.class.should eq Mail::SMTP Mail.delivery_method.class.should eq Mail::SMTP
end end

it "should default to settings for smtp" do it "should default to settings for smtp" do
Mail.delivery_method.class.should eq Mail::SMTP Mail.delivery_method.class.should eq Mail::SMTP
Mail.delivery_method.settings.should eql({:address => "localhost", Mail.delivery_method.settings.should eql({:address => "localhost",
Expand Down Expand Up @@ -119,12 +119,12 @@ class MyRetriever; def initialize(settings); end; end
end end


describe "instance delivery methods" do describe "instance delivery methods" do

it "should copy the defaults defined by Mail.defaults" do it "should copy the defaults defined by Mail.defaults" do
mail = Mail.new mail = Mail.new
mail.delivery_method.class.should eq Mail::SMTP mail.delivery_method.class.should eq Mail::SMTP
end end

it "should be able to change the delivery_method" do it "should be able to change the delivery_method" do
mail = Mail.new mail = Mail.new
mail.delivery_method :file mail.delivery_method :file
Expand All @@ -138,7 +138,7 @@ class MyRetriever; def initialize(settings); end; end
mail.delivery_method.class.should eq Mail::FileDelivery mail.delivery_method.class.should eq Mail::FileDelivery
mail.delivery_method.settings.should eql({:location => tmpdir}) mail.delivery_method.settings.should eql({:location => tmpdir})
end end

it "should not change the default when it changes the delivery_method" do it "should not change the default when it changes the delivery_method" do
mail1 = Mail.new mail1 = Mail.new
mail2 = Mail.new mail2 = Mail.new
Expand All @@ -147,7 +147,7 @@ class MyRetriever; def initialize(settings); end; end
mail1.delivery_method.class.should eq Mail::FileDelivery mail1.delivery_method.class.should eq Mail::FileDelivery
mail2.delivery_method.class.should eq Mail::SMTP mail2.delivery_method.class.should eq Mail::SMTP
end end

it "should not change the default settings when it changes the delivery_method settings" do it "should not change the default settings when it changes the delivery_method settings" do
mail1 = Mail.new mail1 = Mail.new
mail2 = Mail.new mail2 = Mail.new
Expand All @@ -158,7 +158,7 @@ class MyRetriever; def initialize(settings); end; end
end end


end end

describe "retrieving emails via POP3" do describe "retrieving emails via POP3" do
it "should retrieve all emails via POP3" do it "should retrieve all emails via POP3" do
messages = Mail.all messages = Mail.all
Expand All @@ -169,7 +169,7 @@ class MyRetriever; def initialize(settings); end; end
end end
end end
end end

describe "sending emails via SMTP" do describe "sending emails via SMTP" do


before(:each) do before(:each) do
Expand Down Expand Up @@ -199,28 +199,28 @@ class MyRetriever; def initialize(settings); end; end
body 'Yeah sure' body 'Yeah sure'
# add_file 'New Header Image', '/somefile.png' # add_file 'New Header Image', '/somefile.png'
end end

message.deliver! message.deliver!


MockSMTP.deliveries[0][0].should eq message.encoded MockSMTP.deliveries[0][0].should eq message.encoded
MockSMTP.deliveries[0][1].should eq "mikel@test.lindsaar.net" MockSMTP.deliveries[0][1].should eq "mikel@test.lindsaar.net"
MockSMTP.deliveries[0][2].should eq ["ada@test.lindsaar.net"] MockSMTP.deliveries[0][2].should eq ["ada@test.lindsaar.net"]
end end

end end


describe "deliveries" do describe "deliveries" do

class MyDeliveryMethod class MyDeliveryMethod
attr_accessor :settings attr_accessor :settings
def initialize(values = {}); end def initialize(values = {}); end
def deliver!(message); true; end def deliver!(message); true; end
end end

class MyObserver class MyObserver
def self.delivered_email(message); end def self.delivered_email(message); end
end end

class MyDeliveryHandler class MyDeliveryHandler
def deliver_mail(mail) def deliver_mail(mail)
postman = MyDeliveryMethod.new postman = MyDeliveryMethod.new
Expand All @@ -233,7 +233,7 @@ def deliver_mail(mail)
yield yield
end end
end end

before(:each) do before(:each) do
@message = Mail.new do @message = Mail.new do
from 'mikel@test.lindsaar.net' from 'mikel@test.lindsaar.net'
Expand All @@ -243,13 +243,13 @@ def deliver_mail(mail)
end end
@message.delivery_method :test @message.delivery_method :test
end end

describe "adding to Mail.deliveries" do describe "adding to Mail.deliveries" do
it "should add itself to the deliveries collection on mail on delivery" do it "should add itself to the deliveries collection on mail on delivery" do
doing { @message.deliver }.should change(Mail::TestMailer.deliveries, :size).by(1) doing { @message.deliver }.should change(Mail::TestMailer.deliveries, :size).by(1)
end end
end end

describe "perform_deliveries" do describe "perform_deliveries" do
it "should call deliver! on the delivery method by default" do it "should call deliver! on the delivery method by default" do
delivery_agent = MyDeliveryMethod.new delivery_agent = MyDeliveryMethod.new
Expand All @@ -261,7 +261,7 @@ def deliver_mail(mail)
it "should not call deliver if perform deliveries is set to false" do it "should not call deliver if perform deliveries is set to false" do
@message.perform_deliveries = false @message.perform_deliveries = false
delivery_agent = MyDeliveryMethod.new delivery_agent = MyDeliveryMethod.new
@message.should_not_receive(:delivery_method).and_return(delivery_agent) @message.should_not_receive(:delivery_method)
delivery_agent.should_not_receive(:deliver!) delivery_agent.should_not_receive(:deliver!)
@message.deliver @message.deliver
end end
Expand All @@ -276,31 +276,31 @@ def deliver_mail(mail)
doing { @message.deliver }.should_not change(Mail::TestMailer.deliveries, :size) doing { @message.deliver }.should_not change(Mail::TestMailer.deliveries, :size)
end end
end end

describe "observers" do describe "observers" do
it "should tell it's observers that it was told to deliver an email" do it "should tell it's observers that it was told to deliver an email" do
Mail.register_observer(MyObserver) Mail.register_observer(MyObserver)
MyObserver.should_receive(:delivered_email).with(@message).once MyObserver.should_receive(:delivered_email).with(@message).once
@message.deliver @message.deliver
end end

it "should tell it's observers that it was told to deliver an email even if perform_deliveries is false" do it "should tell it's observers that it was told to deliver an email even if perform_deliveries is false" do
Mail.register_observer(MyObserver) Mail.register_observer(MyObserver)
@message.perform_deliveries = false @message.perform_deliveries = false
MyObserver.should_receive(:delivered_email).with(@message).once MyObserver.should_receive(:delivered_email).with(@message).once
@message.deliver @message.deliver
end end

it "should tell it's observers that it was told to deliver an email even if it is using a delivery_handler" do it "should tell it's observers that it was told to deliver an email even if it is using a delivery_handler" do
Mail.register_observer(MyObserver) Mail.register_observer(MyObserver)
@message.delivery_handler = MyYieldingDeliveryHandler.new @message.delivery_handler = MyYieldingDeliveryHandler.new
@message.perform_deliveries = false @message.perform_deliveries = false
MyObserver.should_receive(:delivered_email).with(@message).once MyObserver.should_receive(:delivered_email).with(@message).once
@message.deliver @message.deliver
end end

end end

describe "raise_delivery_errors" do describe "raise_delivery_errors" do
it "should pass on delivery errors if raised" do it "should pass on delivery errors if raised" do
delivery_agent = MyDeliveryMethod.new delivery_agent = MyDeliveryMethod.new
Expand All @@ -317,9 +317,9 @@ def deliver_mail(mail)
doing { @message.deliver }.should_not raise_error(Exception) doing { @message.deliver }.should_not raise_error(Exception)
end end
end end

describe "delivery_handler" do describe "delivery_handler" do

it "should allow you to hand off performing the actual delivery to another object" do it "should allow you to hand off performing the actual delivery to another object" do
delivery_handler = MyYieldingDeliveryHandler.new delivery_handler = MyYieldingDeliveryHandler.new
delivery_handler.should_receive(:deliver_mail).with(@message).exactly(:once) delivery_handler.should_receive(:deliver_mail).with(@message).exactly(:once)
Expand Down Expand Up @@ -349,15 +349,15 @@ def deliver_mail(mail)
@message.delivery_handler = MyDeliveryHandler.new @message.delivery_handler = MyDeliveryHandler.new
doing { @message.deliver }.should_not change(Mail::TestMailer, :deliveries) doing { @message.deliver }.should_not change(Mail::TestMailer, :deliveries)
end end

it "should be able to just yield and let mail do it's thing" do it "should be able to just yield and let mail do it's thing" do
@message.delivery_handler = MyYieldingDeliveryHandler.new @message.delivery_handler = MyYieldingDeliveryHandler.new
@message.should_receive(:do_delivery).exactly(:once) @message.should_receive(:do_delivery).exactly(:once)
@message.deliver @message.deliver
end end

end end

end end

end end

0 comments on commit 6fcf8e7

Please sign in to comment.