Skip to content

Commit

Permalink
Only wrap attachment filenames in double quotes not other params
Browse files Browse the repository at this point in the history
  • Loading branch information
bpot committed Dec 20, 2012
1 parent 9c16d9d commit e74bc60
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 3 deletions.
11 changes: 8 additions & 3 deletions lib/mail/fields/common/common_field.rb
Expand Up @@ -47,11 +47,16 @@ def strip_field(field_name, value)
end
end

WORD_CHAR_WITHOUT_QUOTE = '[\w[^"]]'
WORD_WITHOUT_QUOTE = "#{WORD_CHAR_WITHOUT_QUOTE}+?"
WORD_WITHOUT_QUOTE_FOLLOWED_BY_WSP = "#{WORD_WITHOUT_QUOTE}\\s+?"
PARAM_ENDING = '(\r|\z)'
FILENAME_RE = /\s((filename|name)=((#{WORD_WITHOUT_QUOTE_FOLLOWED_BY_WSP})+?(#{WORD_CHAR_WITHOUT_QUOTE})*?))#{PARAM_ENDING}/

def ensure_filename_quoted(value)
if !value.is_a?(Array) and /(.)*\s(filename|name)=[^"](.+\s)+[^"]/.match value
value.gsub!(/[^=]+$/, '"\\0"')
if value && !value.is_a?(Array) && matches = value.match(FILENAME_RE)
value.sub!(matches[1], "#{matches[2]}=\"#{matches[3]}\"")
end
end

end
end
5 changes: 5 additions & 0 deletions spec/mail/fields/content_type_field_spec.rb
Expand Up @@ -133,6 +133,11 @@
c = Mail::ContentTypeField.new('text/plain; name="Bad filename but at least it is wrapped in quotes.txt"')
c.value.should eq 'text/plain; name="Bad filename but at least it is wrapped in quotes.txt"'
end

it "should only wrap filenames in double quotation marks" do
c = Mail::ContentTypeField.new("image/jpg;\r\n\sname=some .jpg\r\n\ssize=100")
c.value.should eq %Q{image/jpg;\r\n\sname="some .jpg"\r\n\ssize=100}
end
end

describe "instance methods" do
Expand Down

0 comments on commit e74bc60

Please sign in to comment.