Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mail calls non-existent Net::SMTP disable_starttls_auto #1571

Closed
vladimir-mencl-eresearch opened this issue Mar 19, 2023 · 3 comments
Closed

Mail calls non-existent Net::SMTP disable_starttls_auto #1571

vladimir-mencl-eresearch opened this issue Mar 19, 2023 · 3 comments

Comments

@vladimir-mencl-eresearch
Copy link

Hi,

After updating to mail 2.8.0, mail delivery from my app stopped working for me.

I have enable_starttls_auto: false in my Mail delivery_method defaults.

The recent changes to lib/mail/network/delivery_methods/smtp.rb (d91f335) call disable_starttls_auto method that does not exist in net/smtp.rb, resulting into:

2023-03-20 10:43:04 - NoMethodError - undefined method `disable_starttls_auto' for #<Net::SMTP localhost:25 started=false>

I believe this could be easily fixed by replacing the disable_starttls_auto call with disable_starttls - looking at https://github.com/ruby/net-smtp/blob/master/lib/net/smtp.rb, the "auto" behaviour is just tracked by setting @starttls to :auto, and setting it to false would do the right thing.

Cheers,
Vlad
vladimir-mencl-eresearch added a commit to REANNZ/rapidconnect that referenced this issue Mar 19, 2023
@vladimir-mencl-eresearch
fix: revert "Mail: disable opportunistic STARTTLS (localhost)"
73e5642 
This reverts commit af41f21.

Because mikel/mail#1571 makes Ruby Mail break
with `enable_starttls_auto: false` - and exim4 on REANNZ servers no longer
offers TLS, so enabling auto is safe again.
@vladimir-mencl-eresearch
Copy link
Author

FYI @jeremy @eval

@eval
Copy link
Collaborator

eval commented Mar 20, 2023

@vladimir-mencl-eresearch this was fixed in v2.8.1.

@vladimir-mencl-eresearch
Copy link
Author

Ah, I now see it was - should, should have checked before reporting.

vladimir-mencl-eresearch added a commit to REANNZ/rapidconnect that referenced this issue Mar 20, 2023
@vladimir-mencl-eresearch
fix: update mail to get fix for enable_starttls_auto
9edcd68 
Fix for mikel/mail#1571 released in mail 2.8.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eval @vladimir-mencl-eresearch